Protect Annual Table Bin Limits When No Data Are Present#11430
Merged
Protect Annual Table Bin Limits When No Data Are Present#11430
Conversation
rraustad
approved these changes
Feb 23, 2026
Collaborator
rraustad
left a comment
There was a problem hiding this comment.
These changes do look correct.
Collaborator
Author
|
Thanks @rraustad. Tests are clean again, so I'm going to go ahead and merge this. |
Contributor
|
This looks good to me, too (although I'm not a big fan of the C++ ternary operator) |
Collaborator
Author
|
Thanks @JasonGlazer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
#11422 unified the initialization values in annual output tables, but I merged it before realizing that the table bin limits need to be protected for cases when no data are present.
minValandmaxValare being used as sentinel values; however, when no data are present this results in an underflow error here.Description of the purpose of this PR
Pull Request Author
Reviewer